bowenli86 commented on a change in pull request #8784:
[FLINK-12892][table][hive] serialize catalog table to properties for table
discovery service
URL: https://github.com/apache/flink/pull/8784#discussion_r295008984
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericCatalogTable.java
##########
@@ -53,13 +53,6 @@ public GenericCatalogTable copy() {
getSchema().copy(), new
ArrayList<>(getPartitionKeys()), new HashMap<>(getProperties()), getComment());
}
- @Override
- public Map<String, String> toProperties() {
- // TODO: Filter out ANY properties that are not needed for
table discovery.
Review comment:
the property prefix is taken care of already.
I will remove FLINK_IS_GENERIC_KEY. I don't think we need to come up with a
sound list of properties to keep or remove right now, as this PR sets up the
main frame for serialization. Any particular key can be made later on demand.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
