bowenli86 commented on a change in pull request #8784:
[FLINK-12892][table][hive] serialize catalog table to properties for table
discovery service
URL: https://github.com/apache/flink/pull/8784#discussion_r295019001
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericCatalogTable.java
##########
@@ -53,13 +53,6 @@ public GenericCatalogTable copy() {
getSchema().copy(), new
ArrayList<>(getPartitionKeys()), new HashMap<>(getProperties()), getComment());
}
- @Override
- public Map<String, String> toProperties() {
- // TODO: Filter out ANY properties that are not needed for
table discovery.
Review comment:
btw, I think FLINK_IS_GENERIC_KEY may be gone soon as we are going to use
"type" field to define type of the table, like "hive", "csv", "kafka", etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
