zhijiangW commented on a change in pull request #8455: [FLINK-12284,FLINK-12637][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r295108731
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/metrics/AbstractBuffersUsageGauge.java ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.io.network.metrics; + +import org.apache.flink.annotation.VisibleForTesting; +import org.apache.flink.metrics.Gauge; +import org.apache.flink.runtime.io.network.partition.consumer.SingleInputGate; + +/** + * Abstract gauge implementation for calculate the buffer usage percent. + */ +public abstract class AbstractBuffersUsageGauge implements Gauge<Float> { + + protected SingleInputGate[] inputGates; + + @VisibleForTesting + public abstract int calculateUsedBuffers(SingleInputGate inputGate); + + @VisibleForTesting + public abstract int calculateBufferPoolSize(SingleInputGate inputGate); + + AbstractBuffersUsageGauge(SingleInputGate[] inputGates) { + this.inputGates = inputGates; + } + + @Override + public Float getValue() { + int usedBuffers = 0; + int bufferPoolSize = 0; + + for (SingleInputGate inputGate : inputGates) { Review comment: I ever had a concern with the case of multiple input gates. Each `SingleInputGate` corresponds to a different upstream `JobVertex`. If we calculate the value for all the gates, it seems difficult to distinguish the specific usage for individual gate for performance tuning. Another option is we calculate the value separately for each gate, and take the maximum value as the final value if we agree the max usages should bring more concerns for performance tuning. I am not quite sure of it. WDYT?@pnowojski ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
