zhijiangW commented on a change in pull request #8455:
[FLINK-12284,FLINK-12637][Network,Metrics]Fix the incorrect inputBufferUsage
metric in credit-based network mode
URL: https://github.com/apache/flink/pull/8455#discussion_r295108937
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/metrics/InputBufferPoolUsageGauge.java
##########
@@ -18,38 +18,33 @@
package org.apache.flink.runtime.io.network.metrics;
-import org.apache.flink.metrics.Gauge;
import org.apache.flink.runtime.io.network.buffer.BufferPool;
import org.apache.flink.runtime.io.network.partition.consumer.SingleInputGate;
/**
* Gauge metric measuring the input buffer pool usage gauge for {@link
SingleInputGate}s.
*/
-public class InputBufferPoolUsageGauge implements Gauge<Float> {
-
- private final SingleInputGate[] inputGates;
+public class InputBufferPoolUsageGauge extends AbstractBuffersUsageGauge {
public InputBufferPoolUsageGauge(SingleInputGate[] inputGates) {
- this.inputGates = inputGates;
+ super(inputGates);
Review comment:
`checkNotNull`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
