zentol commented on a change in pull request #8761: [FLINK-12842][network] Fix
invalid check released state during ResultPartition#createSubpartitionView
URL: https://github.com/apache/flink/pull/8761#discussion_r295230963
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/PartitionTestUtils.java
##########
@@ -45,4 +52,14 @@ public static ResultPartition createPartition(
.setNumberOfSubpartitions(numChannels)
.build();
}
+
+ static void verifyCreateSubpartitionView(ResultPartitionManager
partitionManager, ResultPartition partition) throws IOException {
Review comment:
rename to `verifyCreateSubpartitionViewThrowsException`; consider passing in
the result of `partition#getPartitionId()` instead.
The partition itself is not used, and as it stands the method is a a bit
ambiguous since it could just as well call
`ResultPartition#createSubpartitionView`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
