Myasuka commented on a change in pull request #8745: [FLINK-11662] Disable task
to fail on checkpoint errors
URL: https://github.com/apache/flink/pull/8745#discussion_r295732037
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -323,9 +323,8 @@ public final void invoke() throws Exception {
CheckpointExceptionHandlerFactory
cpExceptionHandlerFactory = createCheckpointExceptionHandlerFactory();
- synchronousCheckpointExceptionHandler =
cpExceptionHandlerFactory.createCheckpointExceptionHandler(
-
getExecutionConfig().isFailTaskOnCheckpointError(),
- getEnvironment());
+ synchronousCheckpointExceptionHandler =
cpExceptionHandlerFactory
Review comment:
Agree, there is no more benefit to distinguish these two exception handlers.
Already removed the `asynchronousCheckpointExceptionHandler` in `StreamTask`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
