wuchong commented on issue #8695: [FLINK-12805][FLINK-12808][FLINK-12809][table-api] Introduce PartitionableTableSource and PartitionableTableSink and OverwritableTableSink URL: https://github.com/apache/flink/pull/8695#issuecomment-503998573 Hi @aljoscha @godfreyhe , I have updated this PR with following changes: Changes to `PartitionableTableSink`: 1. Rename `getPartitionKeys` to `getPartitionFieldNames` 2. Remove `setStaticPartitions(Map<String, String> partitions)` method - Because partition fields are part of the schema, table sink doesn't need to know the specific static partition, it can be get from records. 3. Change `boolean sortLocalPartition()` method to `boolean requiresSortByPartition(boolean supportSort)` Changes to `PartitionableTableSource`: 1. Rename `getAllPartitions` to `getPartitions` 2. Rename `getPartitionKeys` to `getPartitionFieldNames` 3. Remove `boolean isPartitionPruned()` method
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
