zentol commented on a change in pull request #8804: [FLINK-12883][WIP][runtime]
Add elaborated partition release logic
URL: https://github.com/apache/flink/pull/8804#discussion_r295754218
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
##########
@@ -1790,6 +1819,8 @@ void notifyExecutionChange(
// by filtering out late failure calls, we can save
some work in
// avoiding redundant local failover
if (execution.getGlobalModVersion() ==
globalModVersion) {
+
partitionReleaseStrategy.vertexUnfinished(execution.getVertex().getID());
Review comment:
I don't believe this to be necessary. This branch is only executed if the
new state is FAILED, but this operation here only has any effect if the
execution in question previously arrived in a FINISHED state. Since we don't
allow state transitions from FINISHED to FAILED; this operation should always
be a no-op.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
