WeiZhong94 commented on a change in pull request #8817: [FLINK-12920][python]
Drop support of register_table_sink with parameters field_names and field_types
URL: https://github.com/apache/flink/pull/8817#discussion_r296108555
##########
File path: flink-python/pyflink/table/sinks.py
##########
@@ -45,7 +47,8 @@ class CsvTableSink(TableSink):
:param write_mode: The write mode to specify whether existing files are
overwritten or not.
"""
- def __init__(self, path, field_delimiter=',', num_files=1,
write_mode=None):
+ def __init__(self, field_names, field_types, path, field_delimiter=',',
num_files=1,
+ write_mode=None):
# type: (str, str, int, int) -> None
Review comment:
Revise this type hint to consist with the parameter list?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
