JingsongLi commented on a change in pull request #8530:
[FLINK-12611][table-planner-blink] Make time indicator nullable in blink
URL: https://github.com/apache/flink/pull/8530#discussion_r296626360
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/calcite/FlinkTypeFactory.scala
##########
@@ -128,8 +128,8 @@ class FlinkTypeFactory(typeSystem: RelDataTypeSystem)
extends JavaTypeFactoryImp
case LogicalTypeRoot.TIMESTAMP_WITHOUT_TIME_ZONE =>
val timestampType = t.asInstanceOf[TimestampType]
timestampType.getKind match {
- case TimestampKind.PROCTIME => createProctimeIndicatorType()
- case TimestampKind.ROWTIME => createRowtimeIndicatorType()
+ case TimestampKind.PROCTIME => createProctimeIndicatorType(true)
+ case TimestampKind.ROWTIME => createRowtimeIndicatorType(true)
Review comment:
`createTypeWithNullability` will be called below, So there let be default
true.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
