JingsongLi commented on a change in pull request #8530:
[FLINK-12611][table-planner-blink] Make time indicator nullable in blink
URL: https://github.com/apache/flink/pull/8530#discussion_r296639527
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/plan/batch/sql/join/LookupJoinTest.scala
##########
@@ -68,8 +68,8 @@ class LookupJoinTest extends TableTestBase {
expectExceptionThrown(
"SELECT * FROM MyTable AS T RIGHT JOIN temporalTest " +
"FOR SYSTEM_TIME AS OF T.proctime AS D ON T.a = D.id",
- "Unsupported join type for semi-join RIGHT",
- classOf[IllegalArgumentException]
+ null,
+ classOf[AssertionError]
Review comment:
Not nullable, Non-nullable
If this field is non-nullable and this is a right join, after join, this
field will be nullable.
Calcite does not deal with this correlation, in `getCorrelationUse`, it will
check the input field and output field, their nullable are not the same, so
there is a AssertionError.
IMO, Calcite lack of consideration in this situation, but our lookup join
don't support it too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
