godfreyhe commented on a change in pull request #8793: [FLINK-12904][table-api]
Remove TableSource#getTableStats() interface
URL: https://github.com/apache/flink/pull/8793#discussion_r296627743
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/stats/FlinkStatistic.scala
##########
@@ -86,6 +86,6 @@ object FlinkStatistic {
* @param tableStats The table statistics.
* @return The generated FlinkStatistic
*/
- def of(tableStats: TableStats): FlinkStatistic = new
FlinkStatistic(Option(tableStats))
+ def of(tableStats: TableStats): FlinkStatistic = new
FlinkStatistic(Some(tableStats))
Review comment:
`tableStats` may be null, `Option(null)` is `None`. so we should use
`Option` instead of `Some` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
