GJL commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an
adapter of region failover NG for legacy scheduler
URL: https://github.com/apache/flink/pull/8851#discussion_r297063545
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex.java
##########
@@ -576,7 +576,7 @@ else if (numSources < parallelism) {
*/
public Execution resetForNewExecution(final long timestamp, final long
originatingGlobalModVersion)
throws GlobalModVersionMismatch {
- LOG.debug("Resetting execution vertex {} for new execution.",
getTaskNameWithSubtaskIndex());
+ LOG.info("Resetting execution vertex {} to CREATED state for
new execution.", getTaskNameWithSubtaskIndex());
Review comment:
I find `Resetting [...] to CREATED [...] for new execution` to be a bit
verbose. I would be ok to change the log level to `INFO` so that it is
consistent with.
```
LOG.info("{} ({}) switched from {} to {}.",
getVertex().getTaskNameWithSubtaskIndex(), getAttemptId(), currentState,
targetState);
```
I would make it a separate `[hotfix]` commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
