GJL commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an
adapter of region failover NG for legacy scheduler
URL: https://github.com/apache/flink/pull/8851#discussion_r297072524
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/flip1/FailoverStrategy.java
##########
@@ -34,22 +34,4 @@
* @return set of IDs of vertices to restart
*/
Set<ExecutionVertexID> getTasksNeedingRestart(ExecutionVertexID
executionVertexId, Throwable cause);
-
- //
------------------------------------------------------------------------
- // factory
- //
------------------------------------------------------------------------
-
- /**
- * The factory to instantiate {@link FailoverStrategy}.
- */
- interface Factory {
Review comment:
I cannot give you a definite answer right now but it seems to me that
deleting the `Factory` interface is not needed for the adapter. I think we can
make a decision once the default `SchedulerNG` implementation is done.
The bottom line is that I would revert this change for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
