godfreyhe commented on a change in pull request #8852: [FLINK-12798][table-api][table-planner] Add a proper discover mechanism that will enable switching between Flink & Blink Planner/Executor URL: https://github.com/apache/flink/pull/8852#discussion_r297088461
########## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/delegation/ExecutorFactory.java ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.delegation; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.table.factories.ComponentTableFactory; + +import java.util.Map; + +/** + * Factory that creates {@link Executor}. + * + * <p>This factory is used with Java's Service Provider Interfaces (SPI) for discovering. A factory is + * called with a set of normalized properties that describe the desired configuration. Those properties + * may include execution configurations such as watermark interval, max parallelism etc., table specific + * initialization configuration such as if the queries should be executed in batch mode. + * + * <p><b>Important:</b> The implementations of this interface should also implement method + * <pre>{@code public Executor create(Map<String, String> propertis, StreamExecutionEnvironment executionEnvironmet);} Review comment: nit: propertis -> properties, executionEnvironmet -> executionEnvironment ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
