godfreyhe commented on a change in pull request #8852:
[FLINK-12798][table-api][table-planner] Add a proper discover mechanism that
will enable switching between Flink & Blink Planner/Executor
URL: https://github.com/apache/flink/pull/8852#discussion_r297091193
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/StreamPlannerFactory.java
##########
@@ -43,27 +46,26 @@
* @param catalogManager The catalog manager to look up tables and
views.
* @return instance of a {@link Planner}
*/
- public static Planner lookupPlanner(
- Executor executor,
- TableConfig tableConfig,
- FunctionCatalog functionCatalog,
- CatalogManager catalogManager) {
- try {
- Class<?> clazz =
Class.forName("org.apache.flink.table.planner.StreamPlanner");
- Constructor con = clazz.getConstructor(
- Executor.class,
- TableConfig.class,
- FunctionCatalog.class,
- CatalogManager.class);
+ public Planner create(
Review comment:
please update the javadoc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
