1u0 commented on a change in pull request #8741: [FLINK-12752] Add Option to
Pass Seed for JobID Hash for StandaloneJobClusterEntrypoint
URL: https://github.com/apache/flink/pull/8741#discussion_r297534362
##########
File path:
flink-container/src/main/java/org/apache/flink/container/entrypoint/StandaloneJobClusterConfigurationParserFactory.java
##########
@@ -92,9 +105,23 @@ public StandaloneJobClusterConfiguration
createResult(@Nonnull CommandLine comma
restPort,
savepointRestoreSettings,
jobId,
+ jobIdSeed,
jobClassName);
}
+ private String getJobIdSeed(@Nonnull final CommandLine commandLine)
throws FlinkParseException {
+
+ boolean isJobIdSeedConfigured =
commandLine.hasOption(JOB_ID_SEED_OPTION.getOpt());
+ boolean isJobIdConfigured =
commandLine.hasOption(JOB_ID_OPTION.getOpt());
+
+ if (isJobIdSeedConfigured && isJobIdConfigured) {
Review comment:
The ticket description says that both options (`--job-id` and
`--job--id-seed`) can be passed and they will be resolved by precedence order.
I think here you are making them mutually exclusive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
