1u0 commented on a change in pull request #8741: [FLINK-12752] Add Option to
Pass Seed for JobID Hash for StandaloneJobClusterEntrypoint
URL: https://github.com/apache/flink/pull/8741#discussion_r297553510
##########
File path: flink-end-to-end-tests/test-scripts/test_kubernetes_embedded_job.sh
##########
@@ -64,14 +64,14 @@ fi
eval $(minikube docker-env)
cd "$DOCKER_MODULE_DIR"
-./build.sh --from-local-dist --job-jar
${FLINK_DIR}/examples/batch/WordCount.jar --image-name ${FLINK_IMAGE_NAME}
+./build.sh --from-local-dist --job-artifacts
${FLINK_DIR}/examples/batch/WordCount.jar --image-name ${FLINK_IMAGE_NAME}
cd "$END_TO_END_DIR"
-kubectl create -f ${KUBERNETES_MODULE_DIR}/job-cluster-service.yaml
-envsubst '${FLINK_IMAGE_NAME} ${FLINK_JOB} ${FLINK_JOB_PARALLELISM}
${FLINK_JOB_ARGUMENTS}' < ${CONTAINER_SCRIPTS}/job-cluster-job.yaml.template |
kubectl create -f -
-envsubst '${FLINK_IMAGE_NAME} ${FLINK_JOB_PARALLELISM}' <
${CONTAINER_SCRIPTS}/task-manager-deployment.yaml.template | kubectl create -f -
-kubectl wait --for=condition=complete job/flink-job-cluster --timeout=1h
-kubectl cp `kubectl get pods | awk '/task-manager/ {print
$1}'`:/cache/${OUTPUT_FILE} ${OUTPUT_VOLUME}/${OUTPUT_FILE}
+envsubst '${FLINK_APPLICATION_NAME}' <
${KUBERNETES_MODULE_DIR}/job-cluster-service.yaml.template | kubectl apply -f -
+envsubst '${FLINK_APPLICATION_NAME} ${FLINK_IMAGE_NAME} ${FLINK_JOB}
${FLINK_JOB_PARALLELISM} ${FLINK_JOB_ARGUMENTS}' <
${KUBERNETES_MODULE_DIR}/job-cluster-job.yaml.template | kubectl apply -f -
+envsubst '${FLINK_APPLICATION_NAME} ${FLINK_IMAGE_NAME}
${FLINK_JOB_PARALLELISM}' <
${KUBERNETES_MODULE_DIR}/task-manager-deployment.yaml.template | kubectl apply
-f -
Review comment:
Personally, I'd stick with `kubectl create ...` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
