zhijiangW commented on a change in pull request #8646: [FLINK-12735][network] 
Make shuffle environment implementation independent with IOManager
URL: https://github.com/apache/flink/pull/8646#discussion_r297581901
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/operators/sort/ExternalSortLargeRecordsITCase.java
 ##########
 @@ -71,7 +71,7 @@ public void beforeTest() {
        }
 
        @After
-       public void afterTest() {
+       public void afterTest() throws Exception {
                this.ioManager.close();
                if (!this.ioManager.isProperlyShutDown()) {
 
 Review comment:
   we could add try catch and ignore the exception here. WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to