wsry commented on a change in pull request #8880: [FLINK-12986] [network] Fix
instability of BoundedBlockingSubpartition under memory pressure.
URL: https://github.com/apache/flink/pull/8880#discussion_r298019327
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/MemoryMappedBoundedData.java
##########
@@ -70,15 +69,15 @@
* and {@link BoundedBlockingSubpartitionReader}, such as writing first and
rading after.
* Not obeying these contracts throws NullPointerExceptions.
*/
-class MemoryMappedBuffers implements Closeable {
+final class MemoryMappedBoundedData implements BoundedData {
/** Memory mappings should be at the granularity of page sizes, for
efficiency. */
private static final int PAGE_SIZE =
PageSizeUtil.getSystemPageSizeOrConservativeMultiple();
- /** The encoder to the current memory mapped region we are writing to.
+ /** The the current memory mapped region we are writing to.
Review comment:
The the -> The
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
