wsry commented on a change in pull request #8880: [FLINK-12986] [network] Fix
instability of BoundedBlockingSubpartition under memory pressure.
URL: https://github.com/apache/flink/pull/8880#discussion_r298056812
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionFactory.java
##########
@@ -157,8 +159,9 @@ private static void initializeBoundedBlockingPartitions(
int i = 0;
try {
for (; i < subpartitions.length; i++) {
- subpartitions[i] = new
BoundedBlockingSubpartition(
- i, parent,
ioManager.createChannel().getPathFile().toPath());
+ final File spillFile =
ioManager.createChannel().getPathFile();
+ subpartitions[i] =
+
BoundedBlockingSubpartition.createWithFileAndMemoryMappedReader(i, parent,
spillFile);
Review comment:
Now that three ways of file writing/reading are implemented, why not make it
configurable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
