wuchong commented on a change in pull request #8901: [FLINK-13003][table-planner-blink] Support Temporal TableFunction Join in blink planner URL: https://github.com/apache/flink/pull/8901#discussion_r298453583
########## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/api/TableImpl.scala ########## @@ -48,8 +48,18 @@ class TableImpl(val tableEnv: TableEnvironment, operationTree: QueryOperation) e override def select(fields: Expression*): Table = ??? override def createTemporalTableFunction( Review comment: The another way (using Expression parameter) will be supported when we integrate table-common's `TableImpl` and will add some tests after that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
