wuchong commented on a change in pull request #8901:
[FLINK-13003][table-planner-blink] Support Temporal TableFunction Join in blink
planner
URL: https://github.com/apache/flink/pull/8901#discussion_r298454608
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/join/stream/AbstractStreamingJoinOperator.java
##########
@@ -117,7 +117,9 @@ public void open() throws Exception {
@Override
public void close() throws Exception {
super.close();
- joinCondition.backingJoinCondition.close();
+ if (joinCondition != null) {
Review comment:
I think we should protect it in each close() method. The compiled instance
may not be instantiated when close() is invoked (an exception happens before
instantiation).
This change is not related to this pull request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
