twalthr commented on a change in pull request #8852:
[FLINK-12798][table-api][table-planner] Add a proper discover mechanism that
will enable switching between Flink & Blink Planner/Executor
URL: https://github.com/apache/flink/pull/8852#discussion_r299009658
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/executor/StreamExecutorFactory.java
##########
@@ -21,35 +21,51 @@
import org.apache.flink.annotation.Internal;
import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
import org.apache.flink.table.delegation.Executor;
+import org.apache.flink.table.delegation.ExecutorFactory;
+import org.apache.flink.table.descriptors.DescriptorProperties;
+import org.apache.flink.table.descriptors.PlannerDescriptor;
+
+import java.util.HashMap;
+import java.util.Map;
/**
* Factory to create an implementation of {@link Executor} to use in a
* {@link org.apache.flink.table.api.TableEnvironment}. The {@link
org.apache.flink.table.api.TableEnvironment}
- * should use {@link #create()} method that does not bind to any particular
environment,
+ * should use {@link #create(Map)} method that does not bind to any particular
environment,
* whereas {@link org.apache.flink.table.api.scala.StreamTableEnvironment}
should use
- * {@link #create(StreamExecutionEnvironment)} as it is always backed by some
{@link StreamExecutionEnvironment}
+ * {@link #create(Map, StreamExecutionEnvironment)} as it is always backed by
+ * some {@link StreamExecutionEnvironment}
*/
@Internal
-public class ExecutorFactory {
+public class StreamExecutorFactory implements ExecutorFactory {
+
/**
- * Creates a {@link StreamExecutor} that is backed by given {@link
StreamExecutionEnvironment}.
+ * Creates a corresponding {@link StreamExecutor}.
*
+ * @param properties Static properties of the {@link Executor}, the
same that were used for factory lookup.
* @param executionEnvironment a {@link StreamExecutionEnvironment} to
use while executing Table programs.
- * @return {@link StreamExecutor}
+ * @return instance of a {@link Executor}
*/
- public static Executor create(StreamExecutionEnvironment
executionEnvironment) {
+ public Executor create(Map<String, String> properties,
StreamExecutionEnvironment executionEnvironment) {
Review comment:
nit: the required parameters first?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
