twalthr commented on a change in pull request #8852:
[FLINK-12798][table-api][table-planner] Add a proper discover mechanism that
will enable switching between Flink & Blink Planner/Executor
URL: https://github.com/apache/flink/pull/8852#discussion_r299073546
##########
File path:
flink-table/flink-table-api-scala-bridge/src/main/scala/org/apache/flink/table/api/scala/BatchTableEnvironment.scala
##########
@@ -233,11 +233,12 @@ object BatchTableEnvironment {
classOf[ExecutionEnvironment],
classOf[TableConfig],
classOf[CatalogManager])
+ val defaultCatalog = "default_catalog"
Review comment:
Could we just use `EnvironmentSettings.newInstance().build()` to have just a
single location that defines those constants?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
