wuchong commented on a change in pull request #8844:
[FLINK-12951][table-planner] Add logic to bridge DDL to table source(…
URL: https://github.com/apache/flink/pull/8844#discussion_r299374856
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/TableSchema.java
##########
@@ -56,9 +57,28 @@
private final Map<String, Integer> fieldNameToIndex;
- private TableSchema(String[] fieldNames, DataType[] fieldDataTypes) {
+ private final String[] primaryKeys;
+
+ private final String[][] uniqueKeys;
+
+ private final ComputedColumn[] computedColumns;
Review comment:
Can we move `computedColumns` to some internal classes, e.g.
`InternalTableSchema`. I find that computedColumns is only used internally.
Users don't need to know this information. So it's wired to add this
information to a **public** API class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
