wuchong commented on a change in pull request #8844:
[FLINK-12951][table-planner] Add logic to bridge DDL to table source(…
URL: https://github.com/apache/flink/pull/8844#discussion_r299368725
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/StreamPlanner.scala
##########
@@ -100,22 +100,21 @@ class StreamPlanner(
parsed match {
case insert: SqlInsert =>
- val targetColumnList = insert.getTargetColumnList
Review comment:
Why we removes the partial inserts protect?
I think we should compare the target columns and pass if they are equal to
physical columns (exclude computed columns), and fail if they are not equal to
physical columns.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
