zhijiangW commented on a change in pull request #8704: [FLINK-12812][runtime]
Set resource profiles for task slots
URL: https://github.com/apache/flink/pull/8704#discussion_r299394471
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ShuffleEnvironment.java
##########
@@ -171,4 +171,11 @@ ShuffleIOOwnerContext createShuffleIOOwnerContext(
boolean updatePartitionInfo(
ExecutionAttemptID consumerID,
PartitionInfo partitionInfo) throws IOException,
InterruptedException;
+
+ /**
+ * Gets total memory size for network buffers in bytes.
+ *
+ * @return network memory size in bytes.
+ */
+ long getMemorySize();
Review comment:
My suggestion is not covering the network resources in `ResourceProfile`
atm. As I know, the `ResourceProfile` from execution only covers managed memory
from table api. If so we could also cover the managed memory to match as the
first step, then focus on network resources future because it might involved in
how to expose/calculate network resource on RM/JM side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
