zhijiangW commented on a change in pull request #8704: [FLINK-12812][runtime]
Set resource profiles for task slots
URL: https://github.com/apache/flink/pull/8704#discussion_r299394886
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
##########
@@ -325,6 +321,40 @@ public static TaskManagerServices fromConfiguration(
.createShuffleEnvironment(shuffleEnvironmentContext);
}
+ private static TaskSlotTable createTaskSlotTable(
+ TaskManagerServicesConfiguration
taskManagerServicesConfiguration,
+ long networkMemorySize,
+ long managedMemorySize) {
+
+ final int numOfSlots =
taskManagerServicesConfiguration.getNumberOfSlots();
+ final long heapMemoryBytesPerSlot =
(taskManagerServicesConfiguration.getMemoryType() == MemoryType.HEAP ?
+ taskManagerServicesConfiguration.getMaxJvmHeapMemory()
- managedMemorySize :
+ taskManagerServicesConfiguration.getMaxJvmHeapMemory())
/ numOfSlots;
+ final long networkMemoryBytesPerSlot = networkMemorySize /
numOfSlots;
Review comment:
It might not cover network resource here as I suggested above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
