StefanRRichter commented on a change in pull request #8611:
[FLINK-12693][state] Store state per key-group in CopyOnWriteStateTable
URL: https://github.com/apache/flink/pull/8611#discussion_r299053497
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/StateTable.java
##########
@@ -39,7 +47,8 @@
* @param <N> type of namespace
* @param <S> type of state
*/
-public abstract class StateTable<K, N, S> implements StateSnapshotRestore {
+public abstract class StateTable<K, N, S>
Review comment:
It seems to me like we can now favor composition over inheritance: instead
of making this abstract with two implementations, we could make this a concrete
class and just supply a `MapAndSnapshotFactory` in the constructor. This seem
like the only two things that are abstract methods, building maps and taking
snapshots.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
