StefanRRichter commented on a change in pull request #8611: 
[FLINK-12693][state] Store state per key-group in CopyOnWriteStateTable
URL: https://github.com/apache/flink/pull/8611#discussion_r298967636
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/StateTable.java
 ##########
 @@ -88,7 +118,15 @@ public boolean isEmpty() {
         *
         * @return the number of entries in this {@link StateTable}.
         */
-       public abstract int size();
+       public int size() {
+               int count = 0;
+               for (StateMap<K, N, S> stateMap : state) {
+                       if (stateMap != null) {
 
 Review comment:
   I think this check can be removed now that we have eager initialization of 
the full array

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to