sunjincheng121 commented on issue #8926: [FLINK-13021][table][hive] unify catalog partition implementations URL: https://github.com/apache/flink/pull/8926#issuecomment-508012508 @bowenli86 please wait the CI passed when merging the PR! This commit caused the CI failed as the following error: ``` self = <pyflink.table.tests.test_catalog_completeness.CatalogPartitionAPICompletenessTests testMethod=test_completeness> def test_completeness(self): > self.check_methods() pyflink/testing/test_case_utils.py:210: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ cls = <class 'pyflink.table.tests.test_catalog_completeness.CatalogPartitionAPICompletenessTests'> @classmethod def check_methods(cls): java_primary_methods = {'getClass', 'notifyAll', 'equals', 'hashCode', 'toString', 'notify', 'wait'} java_methods = PythonAPICompletenessTestCase.get_java_class_methods(cls.java_class()) python_methods = cls.get_python_class_methods(cls.python_class()) missing_methods = java_methods - python_methods - cls.excluded_methods() \ - java_primary_methods if len(missing_methods) > 0: raise Exception('Methods: %s in Java class %s have not been added in Python class %s.' > % (missing_methods, cls.java_class(), cls.python_class())) E Exception: Methods: set([u'getComment']) in Java class org.apache.flink.table.catalog.CatalogPartition have not been added in Python class <class 'pyflink.table.catalog.CatalogPartition'>. ``` I mentioned here because this is not the first time, you have merged the PR https://github.com/apache/flink/pull/8786 also caused the CI failed. http://mail-archives.apache.org/mod_mbox/flink-dev/201906.mbox/%3ccajsjtkw4qh6jjepmtg6nuhqvduwp1chlumwvmes10r68azu...@mail.gmail.com%3E
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
