[ 
https://issues.apache.org/jira/browse/FLINK-2634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14877483#comment-14877483
 ] 

ASF GitHub Bot commented on FLINK-2634:
---------------------------------------

Github user vasia commented on the pull request:

    https://github.com/apache/flink/pull/1105#issuecomment-141769161
  
    Hey @andralungu,
    
    I left some minor comments. Apart from those, I think we should also 
address the previous comments on (a) returning an `Integer` instead of 
`Tuple1`, (b) generic vertex keys and (c) allowing any vertex and edge value 
type and replace them internally with `NullValue`.
    I know that other library methods also have these problems (and there's a 
JIRA), but this PR is open, so we can at least fix them for this one.


> Add a Vertex-centric Version of the Tringle Count Library Method
> ----------------------------------------------------------------
>
>                 Key: FLINK-2634
>                 URL: https://issues.apache.org/jira/browse/FLINK-2634
>             Project: Flink
>          Issue Type: Task
>          Components: Gelly
>    Affects Versions: 0.10
>            Reporter: Andra Lungu
>            Assignee: Andra Lungu
>            Priority: Minor
>
> The vertex-centric version of this algorithm receives an undirected graph as 
> input and outputs the total number of triangles formed by the graph's edges.
> The implementation consists of three phases:
> 1). Select neighbours with id greater than the current vertex id.
> 2). Propagate each received value to neighbours with higher id. 
> 3). Compute the number of Triangles by verifying if the final vertex contains 
> the sender's id in its list.
> As opposed to the GAS version, all these three steps will be performed via 
> message passing. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to