JingsongLi commented on a change in pull request #9006:
[FLINK-13107][table-planner-blink] Copy TableApi IT and UT to Blink planner
URL: https://github.com/apache/flink/pull/9006#discussion_r300897422
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/expressions/RexNodeConverter.java
##########
@@ -529,7 +530,8 @@ private RexNode convertOver(List<Expression> children) {
.collect(Collectors.toList());
// assemble bounds
Expression preceding = args.get(2);
- boolean isPhysical = ((ResolvedExpression)
preceding).getOutputDataType().equals(DataTypes.BIGINT());
+ boolean isPhysical =
fromDataTypeToTypeInfo(((ResolvedExpression)
preceding).getOutputDataType()).equals(
Review comment:
Here, I think we need use `LogicalTypeRoot`, because we don't want to judge
`nullable` and `conversionClass`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
