JingsongLi commented on a change in pull request #9006:
[FLINK-13107][table-planner-blink] Copy TableApi IT and UT to Blink planner
URL: https://github.com/apache/flink/pull/9006#discussion_r300896613
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/types/ClassDataTypeConverter.java
##########
@@ -31,6 +35,24 @@
* Convert unknown types by {@link LegacyTypeInformationType}.
*/
public class ClassDataTypeConverter {
+ private static final Map<String, DataType> primitiveClassDataTypes =
new HashMap<>();
+ static {
+
+ // NOTE: this list explicitly excludes data types that need
further parameters
+ // exclusions: DECIMAL, INTERVAL YEAR TO MONTH, MAP, MULTISET,
ROW, NULL, ANY
+ addDefaultDataType(boolean.class, DataTypes.BOOLEAN());
Review comment:
-1 about this change, why we need convert a `int` to `DataType(Integer)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
