[GitHub] [flink] godfreyhe commented on a change in pull request #8962: [FLINK-13076] [table-planner-blink] Bump Calcite dependency to 1.20.0 in blink planner

[GitBox]

godfreyhe commented on a change in pull request #8962: [FLINK-13076] 
[table-planner-blink] Bump Calcite dependency to 1.20.0 in blink planner
URL: https://github.com/apache/flink/pull/8962#discussion_r301367700
 
 

 ##########
 File path: 
flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/plan/batch/sql/join/LookupJoinTest.xml
 ##########
 @@ -233,6 +233,34 @@ FlinkLogicalAggregate(group=[{0}], EXPR$1=[COUNT($1)], 
EXPR$2=[SUM($2)], EXPR$3=
       +- FlinkLogicalSnapshot(period=[$cor0.proctime])
          +- FlinkLogicalCalc(select=[id], where=[>(age, 10)])
             +- FlinkLogicalTableSourceScan(table=[[default_catalog, 
default_database, temporalTest, source: [TestTemporalTable(id, name, age)]]], 
fields=[id, name, age])
+]]>
+    </Resource>
+  </TestCase>
+  <TestCase name="testJoinTemporalTableWithTrueCondition">
+    <Resource name="sql">
+      <![CDATA[
+SELECT * FROM MyTable AS T
+JOIN temporalTest FOR SYSTEM_TIME AS OF T.proctime AS D
+ON true
 
 Review comment:
   before 1.20, the filter will not be removed even the join condition is 
`true`. while after 
[CALCITE-2004](https://issues.apache.org/jira/browse/CALCITE-2004) is fixed in 
1.20, the filter will be removed when join condition is `true`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services