[GitHub] [flink] godfreyhe commented on a change in pull request #8962: [FLINK-13076] [table-planner-blink] Bump Calcite dependency to 1.20.0 in blink planner

[GitBox]

godfreyhe commented on a change in pull request #8962: [FLINK-13076] 
[table-planner-blink] Bump Calcite dependency to 1.20.0 in blink planner
URL: https://github.com/apache/flink/pull/8962#discussion_r301423012
 
 

 ##########
 File path: 
flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/plan/batch/sql/join/LookupJoinTest.xml
 ##########
 @@ -233,6 +233,34 @@ FlinkLogicalAggregate(group=[{0}], EXPR$1=[COUNT($1)], 
EXPR$2=[SUM($2)], EXPR$3=
       +- FlinkLogicalSnapshot(period=[$cor0.proctime])
          +- FlinkLogicalCalc(select=[id], where=[>(age, 10)])
             +- FlinkLogicalTableSourceScan(table=[[default_catalog, 
default_database, temporalTest, source: [TestTemporalTable(id, name, age)]]], 
fields=[id, name, age])
+]]>
+    </Resource>
+  </TestCase>
+  <TestCase name="testJoinTemporalTableWithTrueCondition">
+    <Resource name="sql">
+      <![CDATA[
+SELECT * FROM MyTable AS T
+JOIN temporalTest FOR SYSTEM_TIME AS OF T.proctime AS D
+ON true
 
 Review comment:
   currently, both blink planner and flink planner choose a temporary solution: 
only allow true condition, otherwise throws exception (see: 
[FLINK-7865](https://issues.apache.org/jira/browse/FLINK-7865)).  temporal 
table join will not match the validation, and there are some cases about `left 
temporal table join with non-true condition` in LookupJoinTest. should we 
remove the join validation to support CALCITE-2004 in 1.9 ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services