StephanEwen commented on issue #8740: [FLINK-12763][runtime] Fail job immediately if tasks’ resource needs can not be satisfied. URL: https://github.com/apache/flink/pull/8740#issuecomment-509583218 Looks good overall. And thanks for splitting this into finer grained commits for the review - it helped a lot. I think we may have a latent bug in the `ResourceProfile` - not introduced by this PR, but it may affect the code in this PR. In `isMatching`, the `ResourceProfile` checks whether `(required == UNKNOWN)` which may not be always the case, even is requires is equal to unknown. This probably needs to be `UNKNOWN.equals(required)`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
