JingsongLi commented on a change in pull request #9036:
[FLINK-13112][table-planner-blink] Support LocalZonedTimestampType in blink
URL: https://github.com/apache/flink/pull/9036#discussion_r301876151
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/api/TableConfig.scala
##########
@@ -102,17 +97,19 @@ class TableConfig {
private var conf = GlobalConfiguration.loadConfiguration()
/**
- * Sets the timezone for date/time/timestamp conversions.
- */
- def setTimeZone(timeZone: TimeZone): Unit = {
- require(timeZone != null, "timeZone must not be null.")
- this.timeZone = timeZone
+ * Sets the timezone for date/time/timestamp conversions.
+ */
+ def setTimeZoneId(zoneId: ZoneId): Unit = {
Review comment:
Yeah, I'll keep it be consistent with common TableConfig.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
