JingsongLi commented on a change in pull request #9036:
[FLINK-13112][table-planner-blink] Support LocalZonedTimestampType in blink
URL: https://github.com/apache/flink/pull/9036#discussion_r302528898
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/codegen/CodeGeneratorContext.scala
##########
@@ -526,14 +528,24 @@ class CodeGeneratorContext(val tableConfig: TableConfig)
{
* Adds a reusable TimeZone to the member area of the generated class.
*/
def addReusableTimeZone(): String = {
- val zoneID = tableConfig.getTimeZone.getID
+ val zoneID = TimeZone.getTimeZone(tableConfig.getLocalTimeZone).getID
val stmt =
s"""private static final java.util.TimeZone $DEFAULT_TIMEZONE_TERM =
|
java.util.TimeZone.getTimeZone("$zoneID");""".stripMargin
addReusableMember(stmt)
DEFAULT_TIMEZONE_TERM
}
+ /**
+ * Adds a reusable Time ZoneId to the member area of the generated class.
+ */
+ def addReusableTimeZoneID(): String = {
Review comment:
No, I think it should be used, we now use old time zone, we should use zone
id instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
