[
https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14902843#comment-14902843
]
ASF GitHub Bot commented on FLINK-2111:
---------------------------------------
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-142331659
I think the implementation of `stopExecution()` is fine. You are executing
the call in a separate thread and you are logging exceptions. A blocking stop()
method implemented by a user would not block the actor.
I would catch `Throwable` instead of `RuntimeException`, just to ensure
that really no exception is thrown out of the thread.
This PR is touching very critical components of Flink. I would really
appreciate a review by @tillrohrmann and @StephanEwen.
> Add "stop" signal to cleanly shutdown streaming jobs
> ----------------------------------------------------
>
> Key: FLINK-2111
> URL: https://issues.apache.org/jira/browse/FLINK-2111
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Runtime, JobManager, Local Runtime,
> Streaming, TaskManager, Webfrontend
> Reporter: Matthias J. Sax
> Assignee: Matthias J. Sax
> Priority: Minor
>
> Currently, streaming jobs can only be stopped using "cancel" command, what is
> a "hard" stop with no clean shutdown.
> The new introduced "stop" signal, will only affect streaming source tasks
> such that the sources can stop emitting data and shutdown cleanly, resulting
> in a clean shutdown of the whole streaming job.
> This feature is a pre-requirment for
> https://issues.apache.org/jira/browse/FLINK-1929
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
