[
https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14734914#comment-14734914
]
ASF GitHub Bot commented on FLINK-2111:
---------------------------------------
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-138587744
Yes. That is what I assumed writing the code for this PR. The question is,
if you still simply assume that `cancel` behaves this way or try to enforce it
somehow. Furthermore, the assumption about non-blocking behavior is not well
documented. Should we at least update the JavaDoc for `cancel`?
This question is blocking this PR to get merged. So we need to get to a
conclusion if there is an issue or not (and if I need to change my code or this
PR can just get merged).
I personally would only update the JavaDoc.
> Add "stop" signal to cleanly shutdown streaming jobs
> ----------------------------------------------------
>
> Key: FLINK-2111
> URL: https://issues.apache.org/jira/browse/FLINK-2111
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Runtime, JobManager, Local Runtime,
> Streaming, TaskManager, Webfrontend
> Reporter: Matthias J. Sax
> Assignee: Matthias J. Sax
> Priority: Minor
>
> Currently, streaming jobs can only be stopped using "cancel" command, what is
> a "hard" stop with no clean shutdown.
> The new introduced "stop" signal, will only affect streaming source tasks
> such that the sources can stop emitting data and shutdown cleanly, resulting
> in a clean shutdown of the whole streaming job.
> This feature is a pre-requirment for
> https://issues.apache.org/jira/browse/FLINK-1929
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
