lirui-apache commented on a change in pull request #9088: [FLINK-13012][hive] 
Handle default partition name of Hive table
URL: https://github.com/apache/flink/pull/9088#discussion_r304250604
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/pom.xml
 ##########
 @@ -492,9 +491,9 @@ under the License.
                                                <configuration>
                                                        
<shadeTestJar>false</shadeTestJar>
                                                        <artifactSet>
-                                                               <includes>
 
 Review comment:
   Yeah I think we can remove it. The shaded jar actually only contains classes 
from connector-hive

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to