dawidwys commented on a change in pull request #9061: [FLINK-13078][table-common] Add a logical type parser URL: https://github.com/apache/flink/pull/9061#discussion_r304280725
########## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeParser.java ########## @@ -0,0 +1,916 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.types.logical.utils; + +import org.apache.flink.annotation.PublicEvolving; +import org.apache.flink.api.common.typeutils.TypeSerializerSnapshot; +import org.apache.flink.core.memory.DataInputDeserializer; +import org.apache.flink.table.api.ValidationException; +import org.apache.flink.table.types.logical.AnyType; +import org.apache.flink.table.types.logical.ArrayType; +import org.apache.flink.table.types.logical.BigIntType; +import org.apache.flink.table.types.logical.BinaryType; +import org.apache.flink.table.types.logical.BooleanType; +import org.apache.flink.table.types.logical.CharType; +import org.apache.flink.table.types.logical.DateType; +import org.apache.flink.table.types.logical.DayTimeIntervalType; +import org.apache.flink.table.types.logical.DayTimeIntervalType.DayTimeResolution; +import org.apache.flink.table.types.logical.DecimalType; +import org.apache.flink.table.types.logical.DoubleType; +import org.apache.flink.table.types.logical.FloatType; +import org.apache.flink.table.types.logical.IntType; +import org.apache.flink.table.types.logical.LocalZonedTimestampType; +import org.apache.flink.table.types.logical.LogicalType; +import org.apache.flink.table.types.logical.MapType; +import org.apache.flink.table.types.logical.MultisetType; +import org.apache.flink.table.types.logical.NullType; +import org.apache.flink.table.types.logical.RowType; +import org.apache.flink.table.types.logical.SmallIntType; +import org.apache.flink.table.types.logical.TimeType; +import org.apache.flink.table.types.logical.TimestampType; +import org.apache.flink.table.types.logical.TinyIntType; +import org.apache.flink.table.types.logical.UnresolvedUserDefinedType; +import org.apache.flink.table.types.logical.VarBinaryType; +import org.apache.flink.table.types.logical.VarCharType; +import org.apache.flink.table.types.logical.YearMonthIntervalType; +import org.apache.flink.table.types.logical.YearMonthIntervalType.YearMonthResolution; +import org.apache.flink.table.types.logical.ZonedTimestampType; +import org.apache.flink.table.utils.EncodingUtils; + +import javax.annotation.Nullable; + +import java.util.ArrayList; +import java.util.List; +import java.util.Set; +import java.util.stream.Collectors; +import java.util.stream.Stream; + +/** + * Parser for creating instances of {@link LogicalType} from a serialized string created with + * {@link LogicalType#asSerializableString()}. + * + * <p>In addition to the serializable string representations, this parser also supports common + * shortcuts for certain types. This includes: + * <ul> + * <li>{@code STRING} as a synonym for {@code VARCHAR(INT_MAX)}</li> + * <li>{@code BYTES} as a synonym for {@code VARBINARY(INT_MAX)}</li> + * <li>{@code NUMERIC} and {@code DEC} as synonyms for {@code DECIMAL}</li> + * <li>{@code INTEGER} as a synonym for {@code INT}</li> + * <li>{@code DOUBLE PRECISION} as a synonym for {@code DOUBLE}</li> + * <li>{@code TIME WITHOUT TIME ZONE} as a synonym for {@code TIME}</li> + * <li>{@code TIMESTAMP WITHOUT TIME ZONE} as a synonym for {@code TIMESTAMP}</li> + * <li>{@code type ARRAY} as a synonym for {@code ARRAY<type>}</li> + * <li>{@code type MULTISET} as a synonym for {@code MULTISET<type>}</li> + * <li>{@code ROW(...)} as a synonym for {@code ROW<...>}</li> + * <li>{@code type NULL} as a synonym for {@code type}</li> + * </ul> + * + * <p>Furthermore, it returns {@link UnresolvedUserDefinedType} for unknown types (partially or fully + * qualified such as {@code [catalog].[database].[type]}). + */ +@PublicEvolving +public final class LogicalTypeParser { + + /** + * Parses a type string. All types will be fully resolved except for {@link UnresolvedUserDefinedType}s. + * + * <p>Throws {@link ValidationException} in case of parsing errors. Review comment: use `@throws` annotation for this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
