dawidwys commented on a change in pull request #9061: [FLINK-13078][table-common] Add a logical type parser URL: https://github.com/apache/flink/pull/9061#discussion_r304277888
########## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/UnresolvedUserDefinedType.java ########## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.types.logical; + +import org.apache.flink.annotation.PublicEvolving; +import org.apache.flink.table.api.TableException; +import org.apache.flink.table.utils.EncodingUtils; +import org.apache.flink.util.Preconditions; + +import javax.annotation.Nullable; + +import java.util.List; +import java.util.Objects; +import java.util.Optional; +import java.util.stream.Collectors; +import java.util.stream.Stream; + +/** + * Placeholder type of an unresolved user-defined type that is identified by a partially or fully + * qualified path ({@code [catalog].[database].[type]}). + * + * <p>It assumes that a type has been registered in a catalog and just needs to be resolved to a + * {@link DistinctType} or {@link StructuredType}. + * + * <p>Two unresolved types are considered equal if they share the same path in a stable session context. + * + * @see UserDefinedType + */ +@PublicEvolving +public final class UnresolvedUserDefinedType extends LogicalType { + + private final @Nullable String catalog; + + private final @Nullable String database; + + private final String typeIdentifier; Review comment: How about using `ObjectIdentifier` here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
