GJL commented on a change in pull request #9113: [FLINK-13222] [runtime] Add 
documentation for failover strategy option
URL: https://github.com/apache/flink/pull/9113#discussion_r304798937
 
 

 ##########
 File path: 
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java
 ##########
 @@ -106,17 +106,20 @@
        /**
         * This option specifies the failover strategy, i.e. how the job 
computation recovers from task failures.
         */
-       @Documentation.ExcludeFromDocumentation("The failover strategy feature 
is highly experimental.")
        public static final ConfigOption<String> EXECUTION_FAILOVER_STRATEGY =
                key("jobmanager.execution.failover-strategy")
                        .defaultValue("full")
                        .withDescription(Description.builder()
                                .text("This option specifies how the job 
computation recovers from task failures. " +
                                        "Accepted values are:")
                                .list(
-                                       text("'full': Restarts all tasks."),
-                                       text("'individual': Restarts only the 
failed task. Should only be used if all tasks are independent components."),
 
 Review comment:
   Maybe include in the javadoc of `EXECUTION_FAILOVER_STRATEGY` that 
`individual`, `region-legacy` are intentionally not included in the docs 
because:
   
   1. They worked only in special cases, or there were limitations in the past
   1. the new `region` strategy supersedes them and should always work.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to