azagrebin commented on a change in pull request #9105:
[FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory
size into wrong configuration instance.
URL: https://github.com/apache/flink/pull/9105#discussion_r304893638
##########
File path:
flink-mesos/src/test/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManagerTest.java
##########
@@ -829,4 +839,45 @@ public void testClearStateAfterRevokeLeadership() throws
Exception {
verify(rmServices.schedulerDriver).stop(true);
}};
}
+
+ /**
+ * Tests that RM and TM calculate same slot resource profile.
+ */
+ @Test
+ public void testCreateSlotsPerWorker() throws Exception {
Review comment:
By the common component I meant enabling code reuse as a benefit.
EDIT: Thanks @StephanEwen @GJL for chiming in. Sorry, did not notice the
comments.
If it is too much effort to well-define the shared component or test now, I
am ok to skip it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
