azagrebin commented on a change in pull request #9105:
[FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory
size into wrong configuration instance.
URL: https://github.com/apache/flink/pull/9105#discussion_r304992456
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
##########
@@ -185,6 +199,10 @@ public ResourceManager(
this.jmResourceIdRegistrations = new HashMap<>(4);
this.taskExecutors = new HashMap<>(8);
this.taskExecutorGatewayFutures = new HashMap<>(8);
+
+ this.defaultTaskManagerMemoryMB =
ConfigurationUtils.getTaskManagerHeapMemory(flinkConfig).getMebiBytes();
+ this.numberOfTaskSlots =
flinkConfig.getInteger(TaskManagerOptions.NUM_TASK_SLOTS);
+ this.slotsPerWorker =
updateTaskManagerConfigAndCreateWorkerSlotProfiles(this.flinkConfig,
defaultTaskManagerMemoryMB, numberOfTaskSlots);
Review comment:
ok, I see it is actually not used in `StandaloneResourceManager`.
Yarn and mesos RMs could extend an abstract
`ResourceManagerWithSlotsPerWorker` but it will complicate things.
It will probably need to change with the dynamic memory slicing anyways.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
