wuchong commented on a change in pull request #9174:
[FLINK-13330][table-planner-blink] Remove unnecessary to reduce testing time in
blink
URL: https://github.com/apache/flink/pull/9174#discussion_r305270009
##########
File path:
flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/runtime/sort/BinaryExternalSorterTest.java
##########
@@ -76,11 +75,14 @@ public BinaryExternalSorterTest(
@Parameterized.Parameters(name = "spillCompress-{0} asyncMerge-{1}")
public static Collection<Boolean[]> parameters() {
- return Arrays.asList(
- new Boolean[]{false, false},
- new Boolean[]{false, true},
- new Boolean[]{true, false},
- new Boolean[]{true, true});
+ // To avoid too long testing time, we only tested the default
configuration.
+ // If BinaryExternalSorter has changed, please open it manually
for testing.
+// return Arrays.asList(
+// new Boolean[]{false, false},
+// new Boolean[]{false, true},
+// new Boolean[]{true, false},
+// new Boolean[]{true, true});
Review comment:
Manually testing is hard to guarantee the correctness. I think we need to
find a way to add this to nightly tests in this pull request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
