[
https://issues.apache.org/jira/browse/FLINK-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905445#comment-14905445
]
ASF GitHub Bot commented on FLINK-2651:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1174#issuecomment-142753142
@hsaputra I think the wiki page is not correct any more. Netty was
discussed to be shaded, but was never added to the relocated artifacts.
That was a good decision, IMHO. Dependencies that upgrade well-behaved need
not (and in most cases should not) be shaded. Netty behaved well so far: When
the changed API and behavior, they used a different namespace. Same is true for
the Apache Commons libraries, for example the switch from commons lang version
2 (in the old namespace) to commons lang version 3 (new package name and
artifact id).
Unfortunately, same is not true for Guava, Joda Time, ASM, Protobuf, ...
> Failing NettyServerLowAndHighWatermarkTest
> ------------------------------------------
>
> Key: FLINK-2651
> URL: https://issues.apache.org/jira/browse/FLINK-2651
> Project: Flink
> Issue Type: Bug
> Affects Versions: master
> Reporter: Ufuk Celebi
> Assignee: Ufuk Celebi
>
> https://travis-ci.org/aljoscha/flink/jobs/79610050
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
